fix: remove redundant private helpers#465
Merged
Yunusabdul38 merged 1 commit intoWeb3Novalabs:mainfrom Mar 27, 2026
Merged
Conversation
|
@JTKaduma is attempting to deploy a commit to the shola's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@JTKaduma Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Yunusabdul38
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR audits
predifi-contractauthentication paths and ensures authorization is only required once at the transaction entry point.The change keeps all existing role validation and unauthorized event behavior, but moves shared permission checks into internal helpers that do not call
require_auth(). This avoids redundant auth work on the same address and helps reduce unnecessary gas usage.What Changed
require_auth()only on public contract entry pointsTests
Added regression tests that verify auth is recorded exactly once at the entry point for:
These tests inspect Soroban auth trees directly to ensure we do not re-authenticate the same address within the same invocation path.
Verification
cargo fmtcargo test -p predifi-contract --libAll tests passed.
Closes #416